Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31353 )
Change subject: intel/apollolake: Add HDA to disable_dev function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31353/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31353/2//COMMIT_MSG@8
PS2, Line 8:
Why?
There warning below the added lines should explain enough, no? "Because it was missing"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31353
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4f5e1fad935645830782ba922f55f614c72cf06
Gerrit-Change-Number: 31353
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 13:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment