Change in coreboot[master]: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4

Includes changes related to GPIO pad to configure I2C4 required for UFC

Change-Id: Ica3ac31f10214b8aff3bb64a2c3b42ccfa28bdcd
Signed-off-by: Sugnan Prabhu S 
---
M src/mainboard/intel/jasperlake_rvp/mainboard.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44671/1

diff --git a/src/mainboard/intel/jasperlake_rvp/mainboard.c b/src/mainboard/intel/jasperlake_rvp/mainboard.c
index 3b9dff9..315d47d 100644
--- a/src/mainboard/intel/jasperlake_rvp/mainboard.c
+++ b/src/mainboard/intel/jasperlake_rvp/mainboard.c
@@ -3,10 +3,14 @@
 #include <baseboard/gpio.h>
 #include <baseboard/variants.h>
 #include <device/device.h>
+#include <intelblocks/pcr.h>
 #include <soc/gpio.h>
+#include <soc/pcr_ids.h>
 #include <smbios.h>
 #include <vendorcode/google/chromeos/chromeos.h>

+#define SERIAL_IO_PCR_GPPRVRW4	0x60C
+
 static void mainboard_init(void *chip_info)
 {
    const struct pad_config *pads;
@@ -14,6 +18,9 @@

pads = variant_gpio_table(&num);
    gpio_configure_pads(pads, num);
+
+	if (CONFIG(DRIVERS_INTEL_MIPI_CAMERA))
+		pcr_write32(PID_SERIALIO, SERIAL_IO_PCR_GPPRVRW4, BIT8);
 }

static void mainboard_enable(struct device *dev)

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

Patch Set 2: Code-Review+2

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

Patch Set 2: Code-Review+2

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4

Includes changes related to GPIO pad to configure I2C4 required for UFC

Change-Id: Ica3ac31f10214b8aff3bb64a2c3b42ccfa28bdcd
Signed-off-by: Sugnan Prabhu S 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44671
Tested-by: build bot (Jenkins) 
Reviewed-by: Subrata Banik 
Reviewed-by: Maulik V Vaghela 
Reviewed-by: Aamir Bohra 
---
M src/mainboard/intel/jasperlake_rvp/mainboard.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, approved
  Aamir Bohra: Looks good to me, approved
  Maulik V Vaghela: Looks good to me, approved

diff --git a/src/mainboard/intel/jasperlake_rvp/mainboard.c b/src/mainboard/intel/jasperlake_rvp/mainboard.c
index 3b9dff9..315d47d 100644
--- a/src/mainboard/intel/jasperlake_rvp/mainboard.c
+++ b/src/mainboard/intel/jasperlake_rvp/mainboard.c
@@ -3,10 +3,14 @@
 #include <baseboard/gpio.h>
 #include <baseboard/variants.h>
 #include <device/device.h>
+#include <intelblocks/pcr.h>
 #include <soc/gpio.h>
+#include <soc/pcr_ids.h>
 #include <smbios.h>
 #include <vendorcode/google/chromeos/chromeos.h>

+#define SERIAL_IO_PCR_GPPRVRW4	0x60C
+
 static void mainboard_init(void *chip_info)
 {
    const struct pad_config *pads;
@@ -14,6 +18,9 @@

pads = variant_gpio_table(&num);
    gpio_configure_pads(pads, num);
+
+	if (CONFIG(DRIVERS_INTEL_MIPI_CAMERA))
+		pcr_write32(PID_SERIALIO, SERIAL_IO_PCR_GPPRVRW4, BIT8);
 }

static void mainboard_enable(struct device *dev)

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44671 )

Change subject: mb/intel/jasperlake_rvp: Configure GPIO pad to enable I2C4
......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16657
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16656
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16655
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16654
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16653
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16659
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16658

Please note: This test is under development and might not be accurate at all!