Attention is currently required from: Tarun Tuli, Dinesh Gehlot.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/: Implement an API to get ISH version ......................................................................
Patch Set 10:
(2 comments)
File src/soc/intel/common/block/cse/cse.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174046): https://review.coreboot.org/c/coreboot/+/74209/comment/266f233a_447cc373 PS10, Line 1299: cse_copy_fw_version(resp_version,&(version->ish_partition_info.cur_ish_fw_version)); space required after that ',' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174046): https://review.coreboot.org/c/coreboot/+/74209/comment/1d048644_3021abb4 PS10, Line 1299: cse_copy_fw_version(resp_version,&(version->ish_partition_info.cur_ish_fw_version)); space required before that '&' (ctx:OxV)