Attention is currently required from: Jonathan Zhang, Shuming Chu (Shuming), TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69222 )
Change subject: cpu/x86/topology: Add code to fill in topology on struct path ......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/topology.c:
https://review.coreboot.org/c/coreboot/+/69222/comment/4399bf03_6cd945e3 PS1, Line 33: if (cpuid_max_func >= CPUID_EXTENDED_CPU_TOPOLOGY)
Should we print the failure and die() from the caller if CB_ERR is returned?
absolutely not :-) CPUs that don't implement this for sure exist. Then those CPU simply don't get their topology filled in, which is not a big problem since they tend to not feature thread. Even if those have threads then there is no regression as this currently does not exist.
I'll add a comment to the code to clarify this.