Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76023?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableIa dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for FastPkgCRampDisableIa dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="FastPkgCRampDisableIa" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Id79bbcffd849673268d6ff1904977a074669d28c Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/jinlon/overridetree.cb M src/mainboard/google/hatch/variants/mushu/overridetree.cb M src/mainboard/purism/librem_cnl/devicetree.cb 5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/76023/1
diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index bfbf26e..f60b818 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -23,7 +23,7 @@ register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "FastPkgCRampDisableIa" = "1" + register FastPkgCRampDisableIa = true register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1"
diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index 9571969..1a96b83 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -20,7 +20,7 @@ register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" - register "FastPkgCRampDisableIa" = "1" + register FastPkgCRampDisableIa = true register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1"
diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index e0b9f11..86c3d8d 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -23,7 +23,7 @@ register AcousticNoiseMitigation = true register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "FastPkgCRampDisableIa" = "1" + register FastPkgCRampDisableIa = true register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1"
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 73c4ec1..3c1d53c 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -20,7 +20,7 @@ register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" register "SlowSlewRateForSa" = "2" - register "FastPkgCRampDisableIa" = "1" + register FastPkgCRampDisableIa = true register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1"
diff --git a/src/mainboard/purism/librem_cnl/devicetree.cb b/src/mainboard/purism/librem_cnl/devicetree.cb index ef7ef40..4914bba 100644 --- a/src/mainboard/purism/librem_cnl/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/devicetree.cb @@ -11,7 +11,7 @@ # Acoustic Noise register AcousticNoiseMitigation = true
- register "FastPkgCRampDisableIa" = "1" + register FastPkgCRampDisableIa = true register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1" register "FastPkgCRampDisableFivr" = "1"