Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng.
Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email )
Change subject: mb/google/nissa: Create teliks variant
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/brya/variants/teliks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83408/comment/4ffa0345_71377b24?usp... :
PS10, Line 378: end
This part follows anraggar and can work without using FW config distinction.
yeah, bt there will be unwanted device initialize time and then followed by timeout if we are saying both WLAN is present. In such case SOC logic needs to probe both devices to understand which one is actually present, we could improve the boot latency if we introduce FW config for such 2nd BoM source components in future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83408?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768
Gerrit-Change-Number: 83408
Gerrit-PatchSet: 10
Gerrit-Owner: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 07:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com