Attention is currently required from: Julius Werner, Paul Menzel.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69747?usp=email )
Change subject: arch/arm: Add a few ARM targets as supported by CLANG
......................................................................
Patch Set 25:
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/69747/comment/4fdf6230_3532ea11?usp... :
PS20, Line 1544: default n
Should this be set for x86 somewhere as well? I thought that was already supporting clang?
Done
File src/soc/nvidia/tegra124/Kconfig:
https://review.coreboot.org/c/coreboot/+/69747/comment/0d123e0a_5c9b7e2b?usp... :
PS20, Line 20: default n if SOC_NVIDIA_TEGRA124 && CHROMEOS
Why not move these into the `if SOC_...` blocks below? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88cf8ce16fb6c61c19d615e396f5871179b06fc8
Gerrit-Change-Number: 69747
Gerrit-PatchSet: 25
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 21 Aug 2024 09:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz