Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: arch/x86: Add symbols for CAR MTRRs in linker script
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld@3
PS7, Line 3: #include <cpu/x86/mtrr.h>
What did we need this #include for again? LOG2CEIL is a linker thing.
https://review.coreboot.org/c/coreboot/+/30872/7/src/arch/x86/car.ld@7
PS7, Line 7: _car_mtrr_start
Why wouldn't you just set this symbol to _car_region_start and group the newly added symbols in one hunk with the guard?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef3546d2bfea2d4d8f87aaf8376e5566fd6aaa
Gerrit-Change-Number: 30872
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jun 2020 16:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment