Attention is currently required from: Ravi kumar, Ravi Kumar Bokka, Sudheer Amrabadi. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56642 )
Change subject: google/herobrine: configure gpio to detect board ID. ......................................................................
Patch Set 36:
(12 comments)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/56642/comment/2a03d774_5c9bd3ca PS36, Line 14: if (CONFIG(BOARD_GOOGLE_HEROBRINE)){
space required before the open brace '{'
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/e42ca6f3_15e4c3be PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
space required before the open brace '{'
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/b34320b2_776ec6b2 PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
else should follow close brace '}'
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/cfd23613_6d30186d PS36, Line 19: else if (CONFIG(BOARD_GOOGLE_PIGLIN) || CONFIG(BOARD_GOOGLE_HOGLIN) || CONFIG(BOARD_GOOGLE_SENOR)){
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/69ae0254_656f4794 PS36, Line 20: pins[2] = GPIO(50);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/9dd9c387_2c4a2c3f PS36, Line 20: pins[2] = GPIO(50);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/d94dfce6_f81fd329 PS36, Line 21: pins[1] = GPIO(49);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/09e71e0e_c4f1095a PS36, Line 21: pins[1] = GPIO(49);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/04668d19_1fbd92ea PS36, Line 22: pins[0] = GPIO(48);
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/42dc0cb0_6ec0d09e PS36, Line 22: pins[0] = GPIO(48);
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/402f01a6_93160556 PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){
braces {} are not necessary for single statement blocks
Please fix.
https://review.coreboot.org/c/coreboot/+/56642/comment/93fde59e_55af16c9 PS36, Line 26: if (id == UNDEFINED_STRAPPING_ID){
space required before the open brace '{'
Please fix.
-
Shelley Chen (Code Review)