Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39127 )
Change subject: soc/intel/tigerlake: Add function to dump ME firmware status information
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39127/4/src/soc/intel/tigerlake/me....
File src/soc/intel/tigerlake/me.c:
https://review.coreboot.org/c/coreboot/+/39127/4/src/soc/intel/tigerlake/me....
PS4, Line 16: #include <device/pci_ops.h>
: #include <bootstate.h>
: #include <commonlib/helpers.h>
: #include <console/console.h>
: #include <device/pci.h>
: #include <intelblocks/cse.h>
: #include <soc/me.h>
: #include <soc/pci_devs.h>
: #include <stdint.h>
Only below header files are sufficient. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I831a51f9f482425bd3b97ef1d2404b1d06844d07
Gerrit-Change-Number: 39127
Gerrit-PatchSet: 10
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Mar 2020 21:05:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment