Eric Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62784 )
Change subject: drivers/wifi/generic: Fix is_cnvi function ......................................................................
drivers/wifi/generic: Fix is_cnvi function
dev->ops = &wifi_cnvi_ops need is_cnvi be true. This cause the exclusive statement so is_cnvi never be true in !DEVTREE_EARLY.
BUG=b:224317408 TEST=no assertion in coreboot. [EMERG] ASSERTION ERROR: file 'src/acpi/acpigen_pci.c', line 24
Signed-off-by: Eric Lai eric_lai@quanta.corp-partner.google.com Change-Id: I1ca6312ce164c43021686b483f6579164614cede --- M src/drivers/wifi/generic/generic.c 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/62784/1
diff --git a/src/drivers/wifi/generic/generic.c b/src/drivers/wifi/generic/generic.c index a6936f1..5aaedae 100644 --- a/src/drivers/wifi/generic/generic.c +++ b/src/drivers/wifi/generic/generic.c @@ -43,11 +43,7 @@
static bool is_cnvi(const struct device *dev) { -#if !DEVTREE_EARLY - return dev && dev->ops == &wifi_cnvi_ops; -#else return dev && dev->path.type != DEVICE_PATH_PCI; -#endif }
bool wifi_generic_cnvi_ddr_rfim_enabled(const struct device *dev)