Attention is currently required from: SH Kim. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59609 )
Change subject: mb/google/dedede/var/bugzzy: Add SAR sensor ......................................................................
Patch Set 5:
(6 comments)
File src/mainboard/google/dedede/variants/bugzzy/gpio.c:
https://review.coreboot.org/c/coreboot/+/59609/comment/d4a3f074_3257b86c PS3, Line 51: /* E11 : WIFI_SAR_SENSOR_INT */ : PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE),
We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […]
Done
File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59609/comment/5911b190_ca4f9f17 PS3, Line 51: [PchSerialIoIndexI2C5] = PchSerialIoPci,
We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […]
Done
https://review.coreboot.org/c/coreboot/+/59609/comment/fff1991a_1f07b6b6 PS3, Line 67: #| I2C5 | P-sensor(Wifi) |
We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […]
Done
https://review.coreboot.org/c/coreboot/+/59609/comment/38ed1f0a_fe4a590b PS3, Line 231: device i2c 28 on end
Can we add this as well: […]
Done
https://review.coreboot.org/c/coreboot/+/59609/comment/5a2fbde6_1ce54d77 PS3, Line 239: #register "generic.probed" = "1"
We don't need it.
Done
https://review.coreboot.org/c/coreboot/+/59609/comment/ef5b61a3_7e901825 PS3, Line 338: device pci 19.1 on : chip drivers/i2c/sx9360 : register "desc" = ""SAR Proximity Sensor - Wifi"" : register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E11_IRQ)" : register "uid" = "2" : register "proxraw_strength" = "2" : register "avg_pos_strength" = "16" : register "resolution" = "1024" : device i2c 28 on end : end : end #I2C 5
We will not add Wifi P-sensor for bugzzy, so we can disable I2C5 port and remove the device from tre […]
Done
-
Gwendal Grignou (Code Review)