Jonas Löffelholz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: mb/supermicro/x11-lga1151v2-series: Add support for X11SCH-F
......................................................................
Patch Set 59:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG@23
PS51, Line 23: 84
decimal
Done
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG@25
PS51, Line 25: Tested with Intel Xeon E-2186G and 64 GB ECC RAM.
~30sec.
Done
https://review.coreboot.org/c/coreboot/+/37441/49/Documentation/mainboard/su...
File Documentation/mainboard/supermicro/x11-lga1151v2-series/x11-lga1151v2-series.md:
https://review.coreboot.org/c/coreboot/+/37441/49/Documentation/mainboard/su...
PS49, Line 19: - Intel ME can be cleaned using me_cleaner (~4.5 MB more free space)
Any consequences? Crippling the ME firmware usually breaks things.
This statement is actually wrong, therefore i removed it.
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11-lga1151v2-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/37441/51/src/mainboard/supermicro/x...
PS51, Line 38: .
Use_espi=1?
this works. login is now possible via serial
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37441
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30
Gerrit-Change-Number: 37441
Gerrit-PatchSet: 59
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Jonas Löffelholz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 11:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonas Löffelholz
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment