HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31783
Change subject: src/mainboard/*/*/cstates.c: Drop unused includes ......................................................................
src/mainboard/*/*/cstates.c: Drop unused includes
Change-Id: I315721d6261e558c3f7145c80714262052ce0e49 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p5gc-mx/cstates.c M src/mainboard/asus/p5qc/cstates.c M src/mainboard/foxconn/d41s/cstates.c M src/mainboard/foxconn/g41s-k/cstates.c M src/mainboard/getac/p470/cstates.c M src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c M src/mainboard/gigabyte/ga-g41m-es2l/cstates.c M src/mainboard/ibase/mb899/cstates.c M src/mainboard/intel/d510mo/cstates.c M src/mainboard/intel/d945gclf/cstates.c M src/mainboard/intel/dg43gt/cstates.c M src/mainboard/kontron/986lcd-m/cstates.c M src/mainboard/lenovo/t400/cstates.c M src/mainboard/lenovo/x200/cstates.c M src/mainboard/roda/rk886ex/cstates.c M src/mainboard/roda/rk9/cstates.c 16 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31783/1
diff --git a/src/mainboard/asus/p5gc-mx/cstates.c b/src/mainboard/asus/p5gc-mx/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/asus/p5gc-mx/cstates.c +++ b/src/mainboard/asus/p5gc-mx/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/asus/p5qc/cstates.c b/src/mainboard/asus/p5qc/cstates.c index aa7214d..ab75f49 100644 --- a/src/mainboard/asus/p5qc/cstates.c +++ b/src/mainboard/asus/p5qc/cstates.c @@ -12,8 +12,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801jx/i82801jx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/foxconn/d41s/cstates.c b/src/mainboard/foxconn/d41s/cstates.c index 45b5752..bee1779 100644 --- a/src/mainboard/foxconn/d41s/cstates.c +++ b/src/mainboard/foxconn/d41s/cstates.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/foxconn/g41s-k/cstates.c b/src/mainboard/foxconn/g41s-k/cstates.c index 062add2..3ac18c2 100644 --- a/src/mainboard/foxconn/g41s-k/cstates.c +++ b/src/mainboard/foxconn/g41s-k/cstates.c @@ -15,7 +15,6 @@ */
#include <arch/acpigen.h> -#include <southbridge/intel/i82801gx/i82801gx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/getac/p470/cstates.c b/src/mainboard/getac/p470/cstates.c index 55e6ab8..8939e47 100644 --- a/src/mainboard/getac/p470/cstates.c +++ b/src/mainboard/getac/p470/cstates.c @@ -11,7 +11,7 @@ * GNU General Public License for more details. */
-#include <device/device.h> +#include <arch/acpi.h> #include <arch/acpigen.h> #include <southbridge/intel/i82801gx/i82801gx.h>
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c b/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c index 4d9f4ab..fa542eb 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c +++ b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801gx/i82801gx.h>
static acpi_cstate_t cst_entries[] = {};
diff --git a/src/mainboard/ibase/mb899/cstates.c b/src/mainboard/ibase/mb899/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/ibase/mb899/cstates.c +++ b/src/mainboard/ibase/mb899/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/d510mo/cstates.c b/src/mainboard/intel/d510mo/cstates.c index 45b5752..bee1779 100644 --- a/src/mainboard/intel/d510mo/cstates.c +++ b/src/mainboard/intel/d510mo/cstates.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/d945gclf/cstates.c b/src/mainboard/intel/d945gclf/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/intel/d945gclf/cstates.c +++ b/src/mainboard/intel/d945gclf/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/dg43gt/cstates.c b/src/mainboard/intel/dg43gt/cstates.c index aa7214d..ab75f49 100644 --- a/src/mainboard/intel/dg43gt/cstates.c +++ b/src/mainboard/intel/dg43gt/cstates.c @@ -12,8 +12,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801jx/i82801jx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/kontron/986lcd-m/cstates.c b/src/mainboard/kontron/986lcd-m/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/kontron/986lcd-m/cstates.c +++ b/src/mainboard/kontron/986lcd-m/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/lenovo/t400/cstates.c b/src/mainboard/lenovo/t400/cstates.c index e51accb..34bceaf 100644 --- a/src/mainboard/lenovo/t400/cstates.c +++ b/src/mainboard/lenovo/t400/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { { diff --git a/src/mainboard/lenovo/x200/cstates.c b/src/mainboard/lenovo/x200/cstates.c index e51accb..34bceaf 100644 --- a/src/mainboard/lenovo/x200/cstates.c +++ b/src/mainboard/lenovo/x200/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { { diff --git a/src/mainboard/roda/rk886ex/cstates.c b/src/mainboard/roda/rk886ex/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/roda/rk886ex/cstates.c +++ b/src/mainboard/roda/rk886ex/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/roda/rk9/cstates.c b/src/mainboard/roda/rk9/cstates.c index 0a5f98a..fea9276 100644 --- a/src/mainboard/roda/rk9/cstates.c +++ b/src/mainboard/roda/rk9/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { {
Hello Alexander Couzens, Patrick Rudolph, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31783
to look at the new patch set (#2).
Change subject: src/mainboard/*/*/cstates.c: Drop unused includes ......................................................................
src/mainboard/*/*/cstates.c: Drop unused includes
Change-Id: I315721d6261e558c3f7145c80714262052ce0e49 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p5gc-mx/cstates.c M src/mainboard/asus/p5qc/cstates.c M src/mainboard/foxconn/d41s/cstates.c M src/mainboard/foxconn/g41s-k/cstates.c M src/mainboard/getac/p470/cstates.c M src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c M src/mainboard/gigabyte/ga-g41m-es2l/cstates.c M src/mainboard/ibase/mb899/cstates.c M src/mainboard/intel/d510mo/cstates.c M src/mainboard/intel/d945gclf/cstates.c M src/mainboard/intel/dg43gt/cstates.c M src/mainboard/kontron/986lcd-m/cstates.c M src/mainboard/lenovo/t400/cstates.c M src/mainboard/lenovo/x200/cstates.c M src/mainboard/roda/rk886ex/cstates.c M src/mainboard/roda/rk9/cstates.c 16 files changed, 0 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/31783/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31783 )
Change subject: src/mainboard/*/*/cstates.c: Drop unused includes ......................................................................
Patch Set 5: Code-Review+2
(4 comments)
https://review.coreboot.org/#/c/31783/5/src/mainboard/gigabyte/ga-g41m-es2l/... File src/mainboard/gigabyte/ga-g41m-es2l/cstates.c:
https://review.coreboot.org/#/c/31783/5/src/mainboard/gigabyte/ga-g41m-es2l/... PS5, Line 23: return ARRAY_SIZE(cst_entries); This would want commonlib/helpers? Followup?
https://review.coreboot.org/#/c/31783/5/src/mainboard/lenovo/t400/cstates.c File src/mainboard/lenovo/t400/cstates.c:
https://review.coreboot.org/#/c/31783/5/src/mainboard/lenovo/t400/cstates.c@... PS5, Line 39: return ARRAY_SIZE(cst_entries); same
https://review.coreboot.org/#/c/31783/5/src/mainboard/lenovo/x200/cstates.c File src/mainboard/lenovo/x200/cstates.c:
https://review.coreboot.org/#/c/31783/5/src/mainboard/lenovo/x200/cstates.c@... PS5, Line 39: return ARRAY_SIZE(cst_entries); same
https://review.coreboot.org/#/c/31783/5/src/mainboard/roda/rk9/cstates.c File src/mainboard/roda/rk9/cstates.c:
https://review.coreboot.org/#/c/31783/5/src/mainboard/roda/rk9/cstates.c@34 PS5, Line 34: return ARRAY_SIZE(cst_entries); same
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31783 )
Change subject: src/mainboard/*/*/cstates.c: Drop unused includes ......................................................................
src/mainboard/*/*/cstates.c: Drop unused includes
Change-Id: I315721d6261e558c3f7145c80714262052ce0e49 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31783 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p5gc-mx/cstates.c M src/mainboard/asus/p5qc/cstates.c M src/mainboard/foxconn/d41s/cstates.c M src/mainboard/foxconn/g41s-k/cstates.c M src/mainboard/getac/p470/cstates.c M src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c M src/mainboard/gigabyte/ga-g41m-es2l/cstates.c M src/mainboard/ibase/mb899/cstates.c M src/mainboard/intel/d510mo/cstates.c M src/mainboard/intel/d945gclf/cstates.c M src/mainboard/intel/dg43gt/cstates.c M src/mainboard/kontron/986lcd-m/cstates.c M src/mainboard/lenovo/t400/cstates.c M src/mainboard/lenovo/x200/cstates.c M src/mainboard/roda/rk886ex/cstates.c M src/mainboard/roda/rk9/cstates.c 16 files changed, 0 insertions(+), 22 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/asus/p5gc-mx/cstates.c b/src/mainboard/asus/p5gc-mx/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/asus/p5gc-mx/cstates.c +++ b/src/mainboard/asus/p5gc-mx/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/asus/p5qc/cstates.c b/src/mainboard/asus/p5qc/cstates.c index aa7214d..ab75f49 100644 --- a/src/mainboard/asus/p5qc/cstates.c +++ b/src/mainboard/asus/p5qc/cstates.c @@ -12,8 +12,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801jx/i82801jx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/foxconn/d41s/cstates.c b/src/mainboard/foxconn/d41s/cstates.c index 45b5752..bee1779 100644 --- a/src/mainboard/foxconn/d41s/cstates.c +++ b/src/mainboard/foxconn/d41s/cstates.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/foxconn/g41s-k/cstates.c b/src/mainboard/foxconn/g41s-k/cstates.c index 062add2..3ac18c2 100644 --- a/src/mainboard/foxconn/g41s-k/cstates.c +++ b/src/mainboard/foxconn/g41s-k/cstates.c @@ -15,7 +15,6 @@ */
#include <arch/acpigen.h> -#include <southbridge/intel/i82801gx/i82801gx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/getac/p470/cstates.c b/src/mainboard/getac/p470/cstates.c index 55e6ab8..81d66a1 100644 --- a/src/mainboard/getac/p470/cstates.c +++ b/src/mainboard/getac/p470/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h> #include <southbridge/intel/i82801gx/i82801gx.h>
diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c b/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c index 4d9f4ab..fa542eb 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c +++ b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801gx/i82801gx.h>
static acpi_cstate_t cst_entries[] = {};
diff --git a/src/mainboard/ibase/mb899/cstates.c b/src/mainboard/ibase/mb899/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/ibase/mb899/cstates.c +++ b/src/mainboard/ibase/mb899/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/d510mo/cstates.c b/src/mainboard/intel/d510mo/cstates.c index 45b5752..bee1779 100644 --- a/src/mainboard/intel/d510mo/cstates.c +++ b/src/mainboard/intel/d510mo/cstates.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/d945gclf/cstates.c b/src/mainboard/intel/d945gclf/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/intel/d945gclf/cstates.c +++ b/src/mainboard/intel/d945gclf/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/intel/dg43gt/cstates.c b/src/mainboard/intel/dg43gt/cstates.c index aa7214d..ab75f49 100644 --- a/src/mainboard/intel/dg43gt/cstates.c +++ b/src/mainboard/intel/dg43gt/cstates.c @@ -12,8 +12,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> -#include <southbridge/intel/i82801jx/i82801jx.h>
int get_cst_entries(acpi_cstate_t **entries) { diff --git a/src/mainboard/kontron/986lcd-m/cstates.c b/src/mainboard/kontron/986lcd-m/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/kontron/986lcd-m/cstates.c +++ b/src/mainboard/kontron/986lcd-m/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/lenovo/t400/cstates.c b/src/mainboard/lenovo/t400/cstates.c index e51accb..34bceaf 100644 --- a/src/mainboard/lenovo/t400/cstates.c +++ b/src/mainboard/lenovo/t400/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { { diff --git a/src/mainboard/lenovo/x200/cstates.c b/src/mainboard/lenovo/x200/cstates.c index e51accb..34bceaf 100644 --- a/src/mainboard/lenovo/x200/cstates.c +++ b/src/mainboard/lenovo/x200/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { { diff --git a/src/mainboard/roda/rk886ex/cstates.c b/src/mainboard/roda/rk886ex/cstates.c index 0370a69..ab75f49 100644 --- a/src/mainboard/roda/rk886ex/cstates.c +++ b/src/mainboard/roda/rk886ex/cstates.c @@ -11,7 +11,6 @@ * GNU General Public License for more details. */
-#include <device/device.h> #include <arch/acpigen.h>
int get_cst_entries(acpi_cstate_t **entries) diff --git a/src/mainboard/roda/rk9/cstates.c b/src/mainboard/roda/rk9/cstates.c index 0a5f98a..fea9276 100644 --- a/src/mainboard/roda/rk9/cstates.c +++ b/src/mainboard/roda/rk9/cstates.c @@ -14,8 +14,6 @@ */
#include <arch/acpigen.h> -#include <device/device.h> /* fix for i82801ix.h */ -#include <southbridge/intel/i82801ix/i82801ix.h>
static acpi_cstate_t cst_entries[] = { {
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)