Attention is currently required from: Michał Żygowski, Michał Kopeć. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52781 )
Change subject: cpu/amd/agesa/family14/model_14_init.c: create correct MTRR solution ......................................................................
Patch Set 7:
(2 comments)
File src/cpu/amd/agesa/family14/model_14_init.c:
https://review.coreboot.org/c/coreboot/+/52781/comment/9de9ef51_5ad8ee56 PS7, Line 24: if (acpi_is_wakeup_s3()) { : restore_mtrr(); This will result in different MTRR solutions at resume.
https://review.coreboot.org/c/coreboot/+/52781/comment/2b2272ad_0b48ca3a PS7, Line 32: /* : * Enable ROM caching on BSP we just lost when creating MTRR solution, for : * faster execution : */ : if (boot_cpu()) { : mtrr_use_temp_range(OPTIMAL_CACHE_ROM_BASE, OPTIMAL_CACHE_ROM_SIZE, : MTRR_TYPE_WRPROT); : } code is not executed from ROM at this point.