Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85630?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6316 driver
......................................................................
Patch Set 9:
(4 comments)
File src/soc/mediatek/common/mt6316.c:
https://review.coreboot.org/c/coreboot/+/85630/comment/4b068bd6_4d5ee739?usp... :
PS9, Line 59: 0x%x
%#x
https://review.coreboot.org/c/coreboot/+/85630/comment/3638da49_527994be?usp... :
PS9, Line 86: 0x%x
%#x
https://review.coreboot.org/c/coreboot/+/85630/comment/963b3dfa_007ad297?usp... :
PS9, Line 113: 0x%x
%#x
https://review.coreboot.org/c/coreboot/+/85630/comment/c69f8602_a4323b5f?usp... :
PS9, Line 164: d
%u ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85630?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39e91d64e77cff03281845dfbea565e6ddf748f6
Gerrit-Change-Number: 85630
Gerrit-PatchSet: 9
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 23 Dec 2024 05:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No