Change in coreboot[master]: mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select()
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43445 )
Change subject: mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select() ......................................................................
mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select()
Change-Id: I22b9eb6ead37dbba6807d145468843bd01c94c84 Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/43445/1
diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 6ee6863..d6caedf 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -118,7 +118,7 @@ uint64_t top = 0; uint32_t size = 0, pos = 0;
- if (fw_cfg_e820_select(&size)) { + if (fw_cfg_e820_select(&size) == 0) { while (!fw_cfg_e820_read(&e, &size, &pos)) { uint64_t limit = e.address + e.length; if (e.type == 1 && limit < 4ULL * GiB && limit > top)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43445 )
Change subject: mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select() ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43445 )
Change subject: mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select() ......................................................................
mb/qemu/fw_cfg: Fix return code check for fw_cfg_e820_select()
Change-Id: I22b9eb6ead37dbba6807d145468843bd01c94c84 Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43445 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/emulation/qemu-i440fx/fw_cfg.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 6ee6863..d6caedf 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -118,7 +118,7 @@ uint64_t top = 0; uint32_t size = 0, pos = 0;
- if (fw_cfg_e820_select(&size)) { + if (fw_cfg_e820_select(&size) == 0) { while (!fw_cfg_e820_read(&e, &size, &pos)) { uint64_t limit = e.address + e.length; if (e.type == 1 && limit < 4ULL * GiB && limit > top)
-
Angel Pons (Code Review) -
Nico Huber (Code Review)