Attention is currently required from: Lance Zhao, Raul Rangel, Martin Roth, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59504 )
Change subject: acpi,Makefile: Add preload_acpi_dsdt
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is the last one required for cezanne.
I kind of agree with Tim's sentiment, having each platform kick all of these off manually gets pretty clunky. We kinda had a bit of this discussion in https://review.coreboot.org/c/coreboot/+/56051/8..18/src/lib/Kconfig#b102 already. I think ideally we'd just have one central point in the generic code of each stage (e.g. early in hardwaremain.c for ramstage) where it automatically kicks off all preloads, and the platform shouldn't have to worry about it anymore (other than enabling the right Kconfigs). What are your remaining concerns with that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69ecb947811a2eec861018e3ba5f858155f1c3
Gerrit-Change-Number: 59504
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 19 Nov 2021 23:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment