Attention is currently required from: Nico Huber, Arthur Heymans. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63982 )
Change subject: soc/intel/cmn/spi: Add ACPI SSDT extension for fast SPI ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
The implementation looks good. However TBH, I would prefer a separate […]
Hmm. I have had the thought already to refactor it and pull out the FSPI controller from the generic SPI driver and provide a dedicated one. Not sure how others would think about it. Let me have a look how that could look like. maybe we could do this just for APL for now to see how it will be going. Moving other PCI IDs over should be easy once we have a common sense. What do you think?
File src/soc/intel/common/block/spi/spi.c:
https://review.coreboot.org/c/coreboot/+/63982/comment/ebdf6f44_5ff59cce PS1, Line 192: .acpi_hid = spi_acpi_hid, : .acpi_name = spi_acpi_name,
Technically, these two hooks are only useful if another driver generates […]
Yes, that's true. Will refactor in the next version.