Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35737 )
Change subject: sb/intel/i82801gx: Correctly align register offset
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/sata.c:
https://review.coreboot.org/c/coreboot/+/35737/2/src/southbridge/intel/i8280...
PS2, Line 158: 0x24
if a generic name PCI_BASE_ADDRESS_5 is OK, I'm gonna change the rest of reg 0x24 references in this file to it too.
It's is part of the PCI specification so indeed feel free to do so
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33509befe86ff6e333c559c87a0f45886d737df9
Gerrit-Change-Number: 35737
Gerrit-PatchSet: 2
Gerrit-Owner: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Petr Cvek
petrcvekcz@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Oct 2019 19:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Petr Cvek
petrcvekcz@gmail.com
Gerrit-MessageType: comment