Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 )
Change subject: src/mediatek/mt8186: Implement sdram_size() to get real dram size ......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62065/comment/223c99f8_79a37864 PS17, Line 7: Get dram size from mtk ddr info or CBMEM_ID_MEMINFO
Implement sdram_size() to get real dram size
Ack
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/8d3ab5f7_92091b3b PS15, Line 20: size = mtk_dram_size();
No need, ramstage won't compile if (ENV_ROMSTAGE), the same to if (0).
Done
File src/soc/mediatek/mt8186/emi.c:
https://review.coreboot.org/c/coreboot/+/62065/comment/df97a08d_5191a488 PS16, Line 21: (
One space before "("
Ack
https://review.coreboot.org/c/coreboot/+/62065/comment/122dbf30_f3b46f5a PS16, Line 29: {
Remove
Ack