Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31752 )
Change subject: device/pci: Rewrite PCI MMCONF with symbol reference
......................................................................
Patch Set 4:
(1 comment)
Patch Set 4:
(2 comments)
Is that C standard/spec or compiler specific?
I would say it's the standard, implied by the aliasing rules in general.
https://review.coreboot.org/#/c/31752/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31752/4//COMMIT_MSG@20
PS4, Line 20:
Is there any effect on the boot time?
We are just talking about some 10 assembly instructions that got repeated after every PCI config writes, and we avoid that now. MMIO operation on the bus is a different magnitude of delay, you might just see a millisecond for the entire ramstage that we save.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id112aa5e729ffd8015bb806786bdee38783b7ea9
Gerrit-Change-Number: 31752
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 14 Mar 2019 22:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment