Attention is currently required from: Arthur Heymans, Felix Held, Philipp Hug, Ron Minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83098?usp=email )
Change subject: arch/riscv: Factor out common romstage code
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/sifive/hifive-unmatched/romstage.c:
https://review.coreboot.org/c/coreboot/+/83098/comment/3e7d5253_30313be6?usp... :
PS5, Line 19: console_init();
console_init is already called in the common code before calling this function. […]
UART subsystem depends on `clock_init()`. I meant to remove it and do it like on the unleashed board. I have a few more patches and tests to do on the unmatched board anyway. If you don't mind I will take care of that in another patch.
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb11d2644bf42dacf89ef15b2ec51286fe729d64
Gerrit-Change-Number: 83098
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 01 Jul 2024 16:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de