Change in coreboot[master]: pci_mmio_cfg: Gather everything MMCONF (ECAM) related - coreboot-gerrit

8 Nov 2021


      Attention is currently required from: Nico Huber, Furquan Shaikh.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58332 )
Change subject: pci_mmio_cfg: Gather everything MMCONF (ECAM) related
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/include/device/pci_mmio_cfg.h:
https://review.coreboot.org/c/coreboot/+/58332/comment/1bb55b2a_f1267eec 
PS2, Line 28: #if CONFIG(MMCONF_SUPPORT)
...
...
Isn't this file only included if MMCONF_SUPPORT is true (CB:58331)?  I don't think this block make […]
Sounds good.  Let's get these three patches in and I'll start pushing changes on top.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idda2320c331499dabbee7447f1ad3e81340f2a25
Gerrit-Change-Number: 58332
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Comment-Date: Mon, 08 Nov 2021 16:50:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment