Attention is currently required from: Philipp Deppenwiese, Patrick Rudolph, Christian Walter, Werner Zeh, Yu-Ping Wu. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63285 )
Change subject: Factor TI50/CR50 config ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: Julius' suggestion increases the scope of this change, so I decided to try it out in a separate CL: https://review.coreboot.org/c/coreboot/+/63424
Please have a look at that other one, which I hope will supersede this CL.
File src/drivers/tpm/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63285/comment/e479a54e_37f1e6f6 PS2, Line 9: cr50.c
I guess the next thing is to rename cr50-related files and folders?
Yes, in order to for this CL to not grow too unwieldy, I hope to rename files, and function prefixes in a later CL.
File src/security/vboot/secdata_tpm.c:
https://review.coreboot.org/c/coreboot/+/63285/comment/fee7ba44_4410678c PS2, Line 387: if (CONFIG(CHROMEOS) && (!CONFIG(MAINBOARD_HAS_TPM_GSC)))
Does Ti50 support ZTE?
I am not sure. But when in doubt, I want coreboot to treat ti50 the same was as cr50, then as we further test and refine the ti50 firmware, we can decide if we want to deviate.
-
Jes Klinke (Code Review)