Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63414 )
Change subject: lib/hardwaremain.c: Move creating ACPI structs to bootstate hooks ......................................................................
Patch Set 1:
(3 comments)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/b883bd1c_222d6800 PS1, Line 18: return; Not needed
ramstage-$(CONFIG_ACPI_SOC_NVS) += gnvs.c
File src/lib/hardwaremain.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/0b3b34af_23dc065c PS1, Line 27: #include <vendorcode/google/chromeos/chromeos.h> Probably not needed.
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/63414/comment/428faf03_da142c02 PS1, Line 35: void chromeos_init_chromeos_acpi(void *unused) static void ...