Attention is currently required from: Martin Roth, Matt DeVillier.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61620 )
Change subject: payloads/tianocore: Rework Makefile
......................................................................
Patch Set 23:
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61620/comment/9f8efe19_86d3ce78
PS20, Line 9: BUILD_STR = -q
: BUILD_STR += -a IA32 -a X64 -t COREBOOT
I'd rather not change the build type just to get verbose output, so between the two options, I'd sti […]
Moved - it might seem random, but makes it easier to extract the build target which looks for the Nth word.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cc274e7385dd71c2aae315162cc48444b7eaa5f
Gerrit-Change-Number: 61620
Gerrit-PatchSet: 23
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Mon, 07 Feb 2022 18:30:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment