Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25664 )
Change subject: nb/intel/sandybridge: support more XMP timings ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/ra... PS1, Line 2362: /* XMP gives the CMD rate in clock ticks, not ns */
The value here is offset by 1: 0 for a CMD rate of 1, 1 for a CMD rate of 2. […]
Ah, right
https://review.coreboot.org/#/c/25664/2/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/25664/2/src/northbridge/intel/sandybridge/ra... PS2, Line 2355: * TODO: How to detect "1T" DIMMs ? update the comment ? "Works only for dual XMP 1T DIMMs"