Change in coreboot[master]: mb/google/volteer/eldrid: Describe the privacy_gpio

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ricardo Ribalda (Code Review)

29 Oct 2020 29 Oct '20

3:17 p.m.

Ricardo Ribalda has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Signed-off-by: Ricardo Ribalda ribalda@chromium.org --- M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 2 files changed, 16 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/1

diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c index 4f6650b..3d627e3 100644 --- a/src/mainboard/google/volteer/variants/eldrid/gpio.c +++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c @@ -63,7 +63,7 @@ PAD_CFG_GPO(GPP_C23, 1, DEEP),

device domain 0 on + device pci 14.0 on + chip drivers/usb/acpi + register "desc" = ""Root Hub"" + register "type" = "UPC_TYPE_HUB" + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + register "privacy_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH_ACTIVE_LOW(GPP_D4)" + device usb 3.2 on end + end + end + end + end + device ref dptf on # DPTF Policy for Eldrid board chip drivers/intel/dptf

Attachments:

attachment.htm (text/html — 4.6 KB)

Show replies by date

Ricardo Ribalda (Code Review)

29 Oct 29 Oct

4:28 p.m.

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#2).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Signed-off-by: Ricardo Ribalda ribalda@chromium.org --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 3 files changed, 17 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/2

Ricardo Ribalda (Code Review)

8:05 p.m.

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#3).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/3

Ricardo Ribalda (Code Review)

5 Nov 5 Nov

12:36 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#5).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 5 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

6 Nov 6 Nov

4:29 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 7: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46964/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46964/7/src/mainboard/google/voltee... PS7, Line 230: ACPI_GPIO_INPUT_ACTIVE_LOW Comment here would be helpful just like previous patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 7 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 03:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

10:17 a.m.

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46964/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46964/7/src/mainboard/google/voltee... PS7, Line 230: ACPI_GPIO_INPUT_ACTIVE_LOW

...

Comment here would be helpful just like previous patch.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 7 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 09:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

10:17 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#8).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 8 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

6:02 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 9: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... PS9, Line 230: # The Linux Kernel does not allow an inverted BOTH_LEVEL irq : # So we need to use GpioIO() instead of GpioInt() : # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt : register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)" Thanks 😊

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 9 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 17:02:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:21 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... PS9, Line 230: BOTH_LEVEL BOTH_EDGE

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 9 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 17:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

6:37 p.m.

Ricardo Ribalda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/46964/9/src/mainboard/google/voltee... PS9, Line 230: BOTH_LEVEL

...

BOTH_EDGE

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 9 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 17:37:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Ricardo Ribalda (Code Review)

6:39 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#10).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

BUG=b:171888751

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 10 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-MessageType: newpatchset

Ricardo Ribalda (Code Review)

6:40 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46964

to look at the new patch set (#11).

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

BUG=b:171888751

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/46964/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 11 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

6:52 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

Patch Set 11: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 11 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-Comment-Date: Fri, 06 Nov 2020 17:52:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Nov 9 Nov

8:41 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46964 )

Change subject: mb/google/volteer/eldrid: Describe the privacy_gpio ......................................................................

mb/google/volteer/eldrid: Describe the privacy_gpio

Add information regarding the privacy pin on the overridetree and the gpio.

BUG=b:171888751

Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Signed-off-by: Ricardo Ribalda ribalda@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/46964 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/variants/eldrid/gpio.c M src/mainboard/google/volteer/variants/eldrid/overridetree.cb 3 files changed, 6 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 23dbf68..a5cc196 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -14,6 +14,7 @@ select DRIVERS_SPI_ACPI select DRIVERS_SOUNDWIRE_ALC5682 select DRIVERS_SOUNDWIRE_MAX98373 + select DRIVERS_USB_ACPI select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_SKUID diff --git a/src/mainboard/google/volteer/variants/eldrid/gpio.c b/src/mainboard/google/volteer/variants/eldrid/gpio.c index 4f6650b..3d627e3 100644 --- a/src/mainboard/google/volteer/variants/eldrid/gpio.c +++ b/src/mainboard/google/volteer/variants/eldrid/gpio.c @@ -63,7 +63,7 @@ PAD_CFG_GPO(GPP_C23, 1, DEEP),

/* D4 : IMGCLKOUT0# ==> CAMMERA_SWITCH */ - PAD_CFG_GPI(GPP_D4, NONE, DEEP), + PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH), /* D6 : SRCCLKREQ1# ==> WLAN_CLKREQ_ODL */ PAD_CFG_NF(GPP_D6, NONE, DEEP, NF1), /* D8 : SRCCLKREQ3# ==> SD_CLKREQ_ODL */ diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb index 249505f..91fbbea 100644 --- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb +++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb @@ -227,6 +227,10 @@ chip drivers/usb/acpi register "desc" = ""USB2 Camera"" register "type" = "UPC_TYPE_INTERNAL" + # The Linux Kernel does not allow an inverted BOTH_EDGE irq + # So we need to use GpioIO() instead of GpioInt() + # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt + register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)" device ref usb2_port5 on end end chip drivers/usb/acpi

-- To view, visit https://review.coreboot.org/c/coreboot/+/46964 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ab19a863715ba5a928dd7c16402d398e5475edc Gerrit-Change-Number: 46964 Gerrit-PatchSet: 12 Gerrit-Owner: Ricardo Ribalda ribalda@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tomasz Figa tfiga@google.com Gerrit-MessageType: merged

1272

days inactive

1283

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Ricardo Ribalda (Code Review)
Tim Wawrzynczak (Code Review)