Change in coreboot[master]: mb/google/octopus: Load custom SAR values by SKU ID for Bloog
Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35097 )
Change subject: mb/google/octopus: Load custom SAR values by SKU ID for Bloog ......................................................................
mb/google/octopus: Load custom SAR values by SKU ID for Bloog
Use sku-id to load the SAR values.
SKU ID map 33 to 36 for Bloog 49 to 52 for Blooguard
BUG=b:138180187 BRANCH=octopus TEST=build and verify SAR load by sku-id
Change-Id: Id0bc2609fd1c4eaeb380f8f1532ab30d34e2aeb3 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/variant.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/35097/1
diff --git a/src/mainboard/google/octopus/variants/bloog/variant.c b/src/mainboard/google/octopus/variants/bloog/variant.c index 58b3bc4..6484080 100644 --- a/src/mainboard/google/octopus/variants/bloog/variant.c +++ b/src/mainboard/google/octopus/variants/bloog/variant.c @@ -29,6 +29,9 @@ if (sku_id == SKU_UNKNOWN) return NULL;
+ if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36) + filename = "wifi_sar-bloog.hex"; + if (sku_id == 49 || sku_id == 50 || sku_id == 51 || sku_id == 52) filename = "wifi_sar-blooguard.hex";
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35097 )
Change subject: mb/google/octopus: Load custom SAR values by SKU ID for Bloog ......................................................................
Patch Set 3:
This change is ready for review.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35097 )
Change subject: mb/google/octopus: Load custom SAR values by SKU ID for Bloog ......................................................................
Patch Set 3:
Please help review.
Thanks
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35097 )
Change subject: mb/google/octopus: Load custom SAR values by SKU ID for Bloog ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35097 )
Change subject: mb/google/octopus: Load custom SAR values by SKU ID for Bloog ......................................................................
mb/google/octopus: Load custom SAR values by SKU ID for Bloog
Use sku-id to load the SAR values for Bloog device.
BUG=b:138180187 BRANCH=octopus TEST=build and verify load Bloog SAR by sku-id
Cq-Depend: chromium:1771477 Change-Id: Id0bc2609fd1c4eaeb380f8f1532ab30d34e2aeb3 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35097 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/bloog/variant.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/bloog/variant.c b/src/mainboard/google/octopus/variants/bloog/variant.c index 58b3bc4..6484080 100644 --- a/src/mainboard/google/octopus/variants/bloog/variant.c +++ b/src/mainboard/google/octopus/variants/bloog/variant.c @@ -29,6 +29,9 @@ if (sku_id == SKU_UNKNOWN) return NULL;
+ if (sku_id == 33 || sku_id == 34 || sku_id == 35 || sku_id == 36) + filename = "wifi_sar-bloog.hex"; + if (sku_id == 49 || sku_id == 50 || sku_id == 51 || sku_id == 52) filename = "wifi_sar-blooguard.hex";
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Tony Huang (Code Review)