Attention is currently required from: Angel Pons, Patrick Rudolph.
Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email )
Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ......................................................................
Patch Set 2:
(5 comments)
File src/cpu/intel/model_206ax/chip.h:
https://review.coreboot.org/c/coreboot/+/83269/comment/60b525e7_04212853?usp... : PS1, Line 46: int pl1; /* Long-term power limit*/ : int pl2; /* Short-term power limit*/
I chose this in order to be consistent with the linux kernel's intel-rapl-msr interface (/sys/device […]
Done
File src/cpu/intel/model_206ax/model_206ax.h:
https://review.coreboot.org/c/coreboot/+/83269/comment/7152cb72_dfb1c1c5?usp... : PS1, Line 132: void set_power_limits(u8 power_limit_1_time, struct device *);
Done
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/83269/comment/bbc9a138_e1eb2f5c?usp... : PS1, Line 137: if(conf->pl1) {
Done
https://review.coreboot.org/c/coreboot/+/83269/comment/04ccae0c_7f811f98?usp... : PS1, Line 138: dev_path(dev)
Ack, will remove
Done
https://review.coreboot.org/c/coreboot/+/83269/comment/8dbb6a63_82bd74e2?usp... : PS1, Line 149: if(conf->pl2){
Done