Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Arthur Heymans, Nick Vaccaro, Lean Sheng Tan. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, Arthur Heymans, Nick Vaccaro, Eric Lai, Lean Sheng Tan, Werner Zeh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63737
to look at the new patch set (#3).
Change subject: soc/intel/alderlake: Refactor `pmc_lockdown_cfg` function ......................................................................
soc/intel/alderlake: Refactor `pmc_lockdown_cfg` function
This patch refactors the `pmc_lockdown_cfg()` to remove the helper functions and uses the `setbits32` function to enforce bit locking as applicable.
BUG=b:211954778 TEST=Able to build google/redrix with these changes and boot to OS.
localhost ~ # iotools mmio_read32 0xfe0018c4
0x85000000 (bit 31 is set)
localhost ~ # iotools mmio_read32 0xfe001024
0x00062610 (bits 4, 17 and 18 are set)
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ic96da4638aa689b5fa47a3356986ca5a0343fe36 --- M src/soc/intel/alderlake/lockdown.c 1 file changed, 5 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/63737/3