Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43888 )
Change subject: mb/google/glados/var/cave: Relocate devicetree FSP settings ......................................................................
mb/google/glados/var/cave: Relocate devicetree FSP settings
Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.
Change-Id: I0ddf5da38cc555febcd054e64c5ef7b60a2535ae Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/variants/cave/overridetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/43888/1
diff --git a/src/mainboard/google/glados/variants/cave/overridetree.cb b/src/mainboard/google/glados/variants/cave/overridetree.cb index 9aeb78a..385982b 100644 --- a/src/mainboard/google/glados/variants/cave/overridetree.cb +++ b/src/mainboard/google/glados/variants/cave/overridetree.cb @@ -1,7 +1,5 @@ chip soc/intel/skylake
- register "ScsSdCardEnabled" = "2" - register "PmConfigSlpS4MinAssert" = "1" # 1s register "PmConfigSlpSusMinAssert" = "1" # 500ms
@@ -28,9 +26,6 @@ # TCC of 90C register "tcc_offset" = "10"
- # Use default SD card detect GPIO configuration - register "sdcard_cd_gpio_default" = "GPP_A7" - device domain 0 on device pci 15.0 on chip drivers/i2c/generic @@ -72,7 +67,12 @@ device i2c 1a on end end end # I2C #4 - device pci 1e.6 on end # SDCard + device pci 1e.6 on # SDCard + register "ScsSdCardEnabled" = "2" + + # Use default SD card detect GPIO configuration + register "sdcard_cd_gpio_default" = "GPP_A7" + end device pci 1f.3 on chip drivers/generic/max98357a register "hid" = ""MX98357A""
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43888
to look at the new patch set (#2).
Change subject: mb/google/glados/var/cave: Relocate devicetree settings ......................................................................
mb/google/glados/var/cave: Relocate devicetree settings
Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.
Change-Id: I0ddf5da38cc555febcd054e64c5ef7b60a2535ae Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/variants/cave/overridetree.cb 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/43888/2
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43888 )
Change subject: mb/google/glados/var/cave: Relocate devicetree settings ......................................................................
Abandoned