Change in coreboot[master]: drivers/ipmi: Use correct unsigned int length modifier - coreboot-gerrit

4 Jan 2022


      Attention is currently required from: Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59055 )
Change subject: drivers/ipmi: Use correct unsigned int length modifier
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
...
Currently, they are not. For example: […]
since the custom count should never be negative and from a brief look at the code it's either zero or positive, i'd say that the custom_count elements of the 3 structs should be an unsigned type, so it would be good if you change that imho. maybe add some more reviewers to get another opinion on this?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59055
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0c4266b19d56fa88abc397f305154d473ae1a93
Gerrit-Change-Number: 59055
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 04 Jan 2022 17:30:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment