Attention is currently required from: Raul Rangel, Andrey Pronin, Kangheui Won, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58870 )
Change subject: soc/amd/psp_verstage: Init TPM on S0i3 resume
......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/58870/comment/0fcb20c5_485f5a46
PS3, Line 47: depends on TPM2 && RESUME_PATH_SAME_AS_BOOT
I think the depends on is here because otherwise the code doesn't do anything: […]
Another option is to broaden RESUME_PATH_SAME_AS_BOOT depends to be ACPI_RESUME || PSP_INIT_TPM_ON_S0I3_RESUME. Another option would be to be to disable platform hierarchy unconditionally when PSP_INIT_TPM_ON_S0I3_RESUME is set. Andrey, is there a scenario where we wouldn't disable platform hierarchy after the tpm was reset?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58870
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie511928da6a8b4be62621fd2c4c31a8d1e724d48
Gerrit-Change-Number: 58870
Gerrit-PatchSet: 7
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Andrey Pronin
apronin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 08 Nov 2021 16:59:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment