Attention is currently required from: Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Paul Menzel, Martin Roth, Tim Van Patten, Eric Peers, LeilaCY Lin, Jason Glenesk, Caveh Jalali, Tim Wawrzynczak, Fred Reitberger, Karthikeyan Ramasubramanian, Boris Mittelberg, Felix Held.
EricKY Cheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68471 )
Change subject: common/acpi/dptc: Implement DTTS Proposal
......................................................................
Patch Set 41:
(2 comments)
File src/soc/amd/common/acpi/DTTS.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/ed48afb5_246af2c0
PS39, Line 15: /* If _SB.DDEF is not present, DPTC is not enabled so return early. */
: If (!CondRefOf (_SB.DDEF))
: {
: Return (Zero)
: }
This can be removed once `DTTS()` is called as part of `DPTC()`, which already does this check.
Based on your suggestion, I need your help to clarify the design thinking as below.
You would like to request the code change as below?
1. Include DTTS.asl in DTPC.asl and separate by FEATURE_DYNAMIC_DPTC.
method(DPTC)
{
/* If _SB.DDEF is not present, DPTC is not enabled so return early. */
If (!CondRefOf (_SB.DDEF))
{
Return (Zero)
}
No/Low battery ...etc
#if CONFIG(FEATURE_DYNAMIC_DPTC)
#include <soc/amd/common/acpi/DTTS.asl>
#endif
}
File src/soc/amd/mendocino/acpi/soc.asl:
https://review.coreboot.org/c/coreboot/+/68471/comment/bcfe9507_a9a8dc4b
PS39, Line 33: #if CONFIG(FEATURE_DYNAMIC_DPTC)
: #include <soc/amd/common/acpi/DTTS.asl>
: #else
: #include <soc/amd/common/acpi/dptc.asl>
: #endif
This removes support for the low/no battery boot feature. […]
Follow thermal team's request, DTTS() is designed as customize feature.
Thermal team didn't ask low/no battery mode on the proposal.
DPTC() and DTTS() are independent thermal control methods separate by FEATURE_DYNAMIC_DPTC.
Based on your suggestion, I need your help to clarify the design thinking as below.
You would like to request the code change as below?
1. Include DTTS.asl in DTPC.asl and separate by FEATURE_DYNAMIC_DPTC.
method(DPTC)
{
/* If _SB.DDEF is not present, DPTC is not enabled so return early. */
If (!CondRefOf (_SB.DDEF))
{
Return (Zero)
}
No/Low battery ...etc
#if CONFIG(FEATURE_DYNAMIC_DPTC)
#include <soc/amd/common/acpi/DTTS.asl>
#endif
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I866e5e497e2936984e713029b5f0b6d54cbc9622
Gerrit-Change-Number: 68471
Gerrit-PatchSet: 41
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: LeilaCY Lin
leilacy_lin@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: LeilaCY Lin
leilacy_lin@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 15 Nov 2022 08:12:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment