Ronak Kanabar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/overridetree.cb 5 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45648/1
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 427603c..f32b54a 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -90,6 +90,7 @@ default "Volteer" if BOARD_GOOGLE_VOLTEER default "Volteer2" if BOARD_GOOGLE_VOLTEER2 default "Voxel" if BOARD_GOOGLE_VOXEL + default "Boldar" if BOARD_GOOGLE_BOLDAR
config MAX_CPUS int @@ -126,6 +127,7 @@ default "volteer" if BOARD_GOOGLE_VOLTEER default "volteer2" if BOARD_GOOGLE_VOLTEER2 default "voxel" if BOARD_GOOGLE_VOXEL + default "boldar" if BOARD_GOOGLE_BOLDAR
config VARIANT_HAS_MIPI_CAMERA bool diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 10a9411..c4415d4 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -61,3 +61,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2 + +config BOARD_GOOGLE_BOLDAR + bool "-> Boldar" + select BOARD_GOOGLE_BASEBOARD_VOLTEER diff --git a/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h b/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h b/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h new file mode 100644 index 0000000..b5fa8c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +/* Memory configuration board straps */ +/* Copied from baseboard and may need to change for the new variant. */ +#define GPIO_MEM_CONFIG_0 GPP_C12 +#define GPIO_MEM_CONFIG_1 GPP_C15 +#define GPIO_MEM_CONFIG_2 GPP_C14 +#define GPIO_MEM_CONFIG_3 GPP_D15 + +#endif diff --git a/src/mainboard/google/volteer/variants/boldar/overridetree.cb b/src/mainboard/google/volteer/variants/boldar/overridetree.cb new file mode 100644 index 0000000..32204c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/tigerlake + + device domain 0 on + end + +end
Hello V Sowmya, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Tim Wawrzynczak, siemens-bot,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45648
to look at the new patch set (#2).
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
BUG=b:162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/overridetree.cb 5 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45648/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
Patch Set 3:
"HAVE_SPD_BIN_IN_CBFS is set but SPD_SOURCES is empty" so I think you'll need a mb/google/volteer/variants/boldar/memory/Makefile.inc that declares the SPD_SOURCES (and eventually use the scripts to generate SPDs)
Patrick Georgi has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
Removed Verified+1 by siemens-bot (1003096)
Hello V Sowmya, build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Tim Wawrzynczak, siemens-bot,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45648
to look at the new patch set (#4).
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
Add "Makefile.inc" Genertaded by gen_part_id.go
BUG=b:162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc A src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/boldar/overridetree.cb 8 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45648/4
Hello V Sowmya, build bot (Jenkins), Patrick Georgi, Martin Roth, Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Balaji Manigandan, Tim Wawrzynczak, siemens-bot,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45648
to look at the new patch set (#5).
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
Add "memory/Makefile.inc" Genertaded by gen_part_id.go
BUG=b:162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc A src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/boldar/overridetree.cb 8 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45648/5
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45648/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45648/5//COMMIT_MSG@14 PS5, Line 14: Genertaded generated
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
Patch Set 5: Code-Review+2
Subrata Banik has uploaded a new patch set (#6) to the change originally created by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
Add "memory/Makefile.inc" generated by gen_part_id.go
BUG=b:162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc A src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/boldar/overridetree.cb 8 files changed, 43 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45648/6
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45648/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45648/5//COMMIT_MSG@14 PS5, Line 14: Genertaded
generated
Ack
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45648 )
Change subject: volteer: Create boldar variant ......................................................................
volteer: Create boldar variant
Create the boldar variant of the volteer reference board by copying the template files to a new directory named for the variant.
(Auto-Generated by create_coreboot_variant.sh version 4.2.0).
Add "memory/Makefile.inc" generated by gen_part_id.go
BUG=b:162202257 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_BOLDAR
Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com Change-Id: I92b4b917448d8e5e9176cb983adf7b209956d2c2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45648 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/boldar/include/variant/ec.h A src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h A src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc A src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt A src/mainboard/google/volteer/variants/boldar/overridetree.cb 8 files changed, 43 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index 427603c..f32b54a 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -90,6 +90,7 @@ default "Volteer" if BOARD_GOOGLE_VOLTEER default "Volteer2" if BOARD_GOOGLE_VOLTEER2 default "Voxel" if BOARD_GOOGLE_VOXEL + default "Boldar" if BOARD_GOOGLE_BOLDAR
config MAX_CPUS int @@ -126,6 +127,7 @@ default "volteer" if BOARD_GOOGLE_VOLTEER default "volteer2" if BOARD_GOOGLE_VOLTEER2 default "voxel" if BOARD_GOOGLE_VOXEL + default "boldar" if BOARD_GOOGLE_BOLDAR
config VARIANT_HAS_MIPI_CAMERA bool diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 10a9411..c4415d4 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -61,3 +61,7 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2 + +config BOARD_GOOGLE_BOLDAR + bool "-> Boldar" + select BOARD_GOOGLE_BASEBOARD_VOLTEER diff --git a/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h b/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h b/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h new file mode 100644 index 0000000..b5fa8c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/include/variant/gpio.h @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +/* Memory configuration board straps */ +/* Copied from baseboard and may need to change for the new variant. */ +#define GPIO_MEM_CONFIG_0 GPP_C12 +#define GPIO_MEM_CONFIG_1 GPP_C15 +#define GPIO_MEM_CONFIG_2 GPP_C14 +#define GPIO_MEM_CONFIG_3 GPP_D15 + +#endif diff --git a/src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc b/src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc new file mode 100644 index 0000000..ed894fe --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += ddr4-spd-empty.hex # ID = 0(0b0000) Parts = EMPTY diff --git a/src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt new file mode 100644 index 0000000..2e3fcbc --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/memory/dram_id.generated.txt @@ -0,0 +1,2 @@ +DRAM Part Name ID to assign +EMPTY 0 (0000) diff --git a/src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt new file mode 100644 index 0000000..7f7204c --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/memory/mem_list_variant.txt @@ -0,0 +1 @@ +EMPTY diff --git a/src/mainboard/google/volteer/variants/boldar/overridetree.cb b/src/mainboard/google/volteer/variants/boldar/overridetree.cb new file mode 100644 index 0000000..32204c5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/boldar/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/tigerlake + + device domain 0 on + end + +end
-
Patrick Georgi (Code Review) -
Ronak Kanabar (Code Review)
-
Subrata Banik (Code Review)
-
Tim Wawrzynczak (Code Review)