HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45559 )
Change subject: mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax
Change-Id: I08c6d706aa409563cf2c407352e8de5ecc994bda Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/thermal.asl 1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45559/1
diff --git a/src/mainboard/getac/p470/acpi/thermal.asl b/src/mainboard/getac/p470/acpi/thermal.asl index 6e3dc22..4e31ef3 100644 --- a/src/mainboard/getac/p470/acpi/thermal.asl +++ b/src/mainboard/getac/p470/acpi/thermal.asl @@ -17,11 +17,11 @@ // Convert from °C to 1/10 Kelvin Method(DEGR, 1, NotSerialized) { - Store(Arg0, Local0) + Local0 = Arg0 // 10ths of degrees - Multiply(Local0, 10, Local0) + Local0 *= 10 // 0°C is 273.15 K, we need to round it. - Add(Local0, 2732, Local0) + Local0 += 2732 Return(Local0) }
@@ -35,24 +35,24 @@ // Critical shutdown temperature Method (_CRT, 0, Serialized) { - Store(_SB.PCI0.LPCB.EC0.CRTT, Local0) - Store(DEGR(Local0), Local0) + Local0 = _SB.PCI0.LPCB.EC0.CRTT + Local0 = DEGR (Local0) Return(Local0) }
// CPU throttling start temperature Method (_PSV, 0, Serialized) { - Store(_SB.PCI0.LPCB.EC0.CTRO, Local0) - Store(DEGR(Local0), Local0) + Local0 = _SB.PCI0.LPCB.EC0.CTRO + Local0 = DEGR (Local0) Return(Local0) }
// Get DTS Temperature Method (_TMP, 0, Serialized) { - Store(_SB.PCI0.LPCB.EC0.CTMP, Local0) - Store(DEGR(Local0), Local0) + Local0 = _SB.PCI0.LPCB.EC0.CTMP + Local0 = DEGR (Local0) Return(Local0) }
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45559 )
Change subject: mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45559/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45559/1//COMMIT_MSG@8 PS1, Line 8: this should build identical w/ TIMELESS, does it?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45559 )
Change subject: mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax ......................................................................
Patch Set 1:
(1 comment)
Thank you
https://review.coreboot.org/c/coreboot/+/45559/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45559/1//COMMIT_MSG@8 PS1, Line 8:
this should build identical w/ TIMELESS, does it?
Tested with BUILD_TIMELESS=1, it remains identical.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45559
to look at the new patch set (#2).
Change subject: mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax ......................................................................
mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax
Tested with BUILD_TIMELESS=1, it remains identical.
Change-Id: I08c6d706aa409563cf2c407352e8de5ecc994bda Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/getac/p470/acpi/thermal.asl 1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45559/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45559 )
Change subject: mb/getac/p470/acpi: Convert 'thermal.asl' to ASL 2.0 syntax ......................................................................
Abandoned
see 45555
-
HAOUAS Elyes (Code Review) -
Tim Wawrzynczak (Code Review)