Attention is currently required from: Forest Mittelberg, Peter Marheine.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84300?usp=email )
Change subject: [RFC] ec/google/chromeec: Guard reading long battery strings ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Do you know what Windows is doing that causes it to hang, or did you just bisect to the battery chan […]
Bisected to find the commit, then reverted to confirm.
I completely agree that the GSC has no bearing here, it was just the simplest way for me to work around the issue for the affected platforms. I'm open to other implementations.
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/84300/comment/6b127dd7_603c1031?usp... : PS1, Line 174: #if CONFIG(TPM_GOOGLE_CR50) || CONFIG(TPM_GOOGLE_TI50)
Seems simpler to put these guards inside BRSX (short-circuit to `BRSS=0`), so it only needs to be in […]
agreed, can do that once we agree that these guards are the least-worst way to work around the problem :)