[S] Change in coreboot[main]: arch/arm64/armv8/mmu: Improve log format - coreboot-gerrit

30 Jul 2024


      Attention is currently required from: Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83652?usp=email )
Change subject: arch/arm64/armv8/mmu: Improve log format
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83652/comment/40b83169_5eeec342?usp... :
PS2, Line 9: When using format string with "%p", "(nil)" will be printed for address
...
See this in unit tests, not on a real ARM device. Let me modify the commit message.
I don't feel like we should modify coreboot's code because of printing behavior that only happens in some random libc's `printf()` implementation tbh.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83652?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib29c201e1b096b9c7cd750d2541923616bc858ac
Gerrit-Change-Number: 83652
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Tue, 30 Jul 2024 21:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com