Change in ...coreboot[master]: ec/google/wilco: Add S0ix support handlers

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31094

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/1

diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl
index f9b16b5..db4acd4 100644
--- a/src/ec/google/wilco/acpi/ec.asl
+++ b/src/ec/google/wilco/acpi/ec.asl
@@ -47,6 +47,9 @@
    	/* Indicate to EC that OS is ready for queries */
    	W (ERDY, Arg1)

+		/* Indicate that the OS supports S0ix */
+		W (CSOS, One)
+
    	/* Tell EC to stop emulating PS/2 mouse */
    	W (PS2M, Zero)

@@ -140,6 +143,17 @@
    	Return (ECRW (Arg0, Arg1))
    }

+	/*
+	 * Tell EC that the OS is entering or exiting S0ix
+	Method (S0IX, 1, Serialized)
+	{
+		If (Arg0) {
+			W (CSEX, One)
+		} Else {
+			W (CSEX, Zero)
+		}
+	}
+
    #include "ec_dev.asl"
    #include "ec_ram.asl"
    #include "ac.asl"
diff --git a/src/ec/google/wilco/acpi/ec_ram.asl b/src/ec/google/wilco/acpi/ec_ram.asl
index 1563a3c..1e5d7cb 100644
--- a/src/ec/google/wilco/acpi/ec_ram.asl
+++ b/src/ec/google/wilco/acpi/ec_ram.asl
@@ -142,3 +142,5 @@
 Name (DWTH, Package () { 0x36, 0xff, WR })	/* DPTF: Write Trip High */
 Name (DWHY, Package () { 0x37, 0xff, WR })	/* DPTF: Write Hysteresis */
 Name (DWTQ, Package () { 0x38, 0xff, WR })	/* DPTF: Write Trip Query */
+Name (CSOS, Package () { 0xb8, 0xff, WR })	/* OS support for S0ix */
+Name (CSEX, Package () { 0xb9, 0xff, WR })	/* OS enter(1)/exit(0) S0ix */

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31094/1/src/ec/google/wilco/acpi/ec.asl 
File src/ec/google/wilco/acpi/ec.asl:

https://review.coreboot.org/#/c/31094/1/src/ec/google/wilco/acpi/ec.asl@147 
PS1, Line 147: 	 * Tell EC that the OS is entering or exiting S0ix
missing */ for the comment

[Duncan Laurie (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31094

to look at the new patch set (#2).

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/2

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded a new patch set (#3) to the change originally created by Duncan Laurie. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 16 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/3

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 3:

Sorry. Third patchset went by mistake. Will fix that

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded a new patch set (#4) to the change originally created by Duncan Laurie. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 17 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/4

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 5: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 6: Code-Review+2

[Duncan Laurie (Code Review)]

Hello Paul Menzel, build bot (Jenkins), Shaunak Saha, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31094

to look at the new patch set (#7).

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/7

[Duncan Laurie (Code Review)]

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 7:

I added a debug output before sending the EC command so it is easy to ensure that the kernel path to call this function is working.

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 7: Code-Review+1

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded a new patch set (#8) to the change originally created by Duncan Laurie. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 19 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/31094/8

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 8: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

Patch Set 8: Code-Review+2

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31094 )

Change subject: ec/google/wilco: Add S0ix support handlers
......................................................................

ec/google/wilco: Add S0ix support handlers

1) In the EC _REG method set the flag indicating S0ix support in the OS.

2) Add a function that can be called by the LPI _DSM method to indicate
to the EC that the OS is entering or exiting S0ix.

BUG=b:73137291

Change-Id: Iddc33a08542a6657694c47a9fda1b02dd39d89f7
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/31094
Reviewed-by: Lijian Zhao 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Shaunak Saha 
Tested-by: build bot (Jenkins) 
---
M src/ec/google/wilco/acpi/ec.asl
M src/ec/google/wilco/acpi/ec_ram.asl
2 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Lijian Zhao: Looks good to me, approved
  Shaunak Saha: Looks good to me, but someone else must approve

diff --git a/src/ec/google/wilco/acpi/ec.asl b/src/ec/google/wilco/acpi/ec.asl
index f9b16b5..be80b2d 100644
--- a/src/ec/google/wilco/acpi/ec.asl
+++ b/src/ec/google/wilco/acpi/ec.asl
@@ -47,6 +47,9 @@
    	/* Indicate to EC that OS is ready for queries */
    	W (ERDY, Arg1)

+		/* Indicate that the OS supports S0ix */
+		W (CSOS, One)
+
    	/* Tell EC to stop emulating PS/2 mouse */
    	W (PS2M, Zero)

@@ -140,6 +143,20 @@
    	Return (ECRW (Arg0, Arg1))
    }

+	/*
+	 * Tell EC that the OS is entering or exiting S0ix
+	 */
+	Method (S0IX, 1, Serialized)
+	{
+		If (Arg0) {
+			Printf ("EC Enter S0ix")
+			W (CSEX, One)
+		} Else {
+			Printf ("EC Exit S0ix")
+			W (CSEX, Zero)
+		}
+	}
+
    #include "ec_dev.asl"
    #include "ec_ram.asl"
    #include "ac.asl"
diff --git a/src/ec/google/wilco/acpi/ec_ram.asl b/src/ec/google/wilco/acpi/ec_ram.asl
index 1563a3c..1e5d7cb 100644
--- a/src/ec/google/wilco/acpi/ec_ram.asl
+++ b/src/ec/google/wilco/acpi/ec_ram.asl
@@ -142,3 +142,5 @@
 Name (DWTH, Package () { 0x36, 0xff, WR })	/* DPTF: Write Trip High */
 Name (DWHY, Package () { 0x37, 0xff, WR })	/* DPTF: Write Hysteresis */
 Name (DWTQ, Package () { 0x38, 0xff, WR })	/* DPTF: Write Trip Query */
+Name (CSOS, Package () { 0xb8, 0xff, WR })	/* OS support for S0ix */
+Name (CSEX, Package () { 0xb9, 0xff, WR })	/* OS enter(1)/exit(0) S0ix */