[L] Change in coreboot[master]: mb/google/nissa/var/yaviks: Update devicetree based on FW_CONFIG for ... - coreboot-gerrit

11 Apr 2023


      Attention is currently required from: Chen-Tsung Hsieh, Tony Huang, Robert Chen, Shou-Chieh Hsu, Shon Wang.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74261 )
Change subject: mb/google/nissa/var/yaviks: Update devicetree based on FW_CONFIG for yavilla
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/google/brya/variants/yaviks/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74261/comment/6dc379f5_5bd4bec6 
PS7, Line 562: MLB
Is it MLB or DB? why do you need to probe DB_USB if it's on MLB?
https://review.coreboot.org/c/coreboot/+/74261/comment/e84bad16_c8eaccd5 
PS7, Line 572: MLB
same here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74261
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38dbcf5920d12adb1f84885bdfa4c2f2faf2eb9e
Gerrit-Change-Number: 74261
Gerrit-PatchSet: 7
Gerrit-Owner: Tony Huang tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Reviewer: Derek Huang derekhuang@google.com
Gerrit-Reviewer: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Wisley Chen wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh chentsung@chromium.org
Gerrit-Attention: Tony Huang tony-huang@quanta.corp-partner.google.com
Gerrit-Attention: Robert Chen robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu shouchieh@google.com
Gerrit-Attention: Shon Wang shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Apr 2023 07:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment