build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30182 )
Change subject: IntelFB: Add support for Intel font driver ......................................................................
Patch Set 1:
(21 comments)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h File src/drivers/intel/fb/fbdriver.h:
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h@8 PS1, Line 8: FB_POS_CENTER=0, spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.h@12 PS1, Line 12: }FB_POS; space required after that close brace '}'
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c File src/drivers/intel/fb/fbdriver.c:
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@41 PS1, Line 41: unsigned char *glyph = font8x16 + ((ch & 0xFF) * FONT_HEIGHT); code indent should use tabs where possible
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@41 PS1, Line 41: unsigned char *glyph = font8x16 + ((ch & 0xFF) * FONT_HEIGHT); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@42 PS1, Line 42: return glyph[y/FONT_SCALE] & (1 << x/FONT_SCALE); code indent should use tabs where possible
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@42 PS1, Line 42: return glyph[y/FONT_SCALE] & (1 << x/FONT_SCALE); please, no spaces at the start of a line
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@53 PS1, Line 53: status = fsp_fill_lb_framebuffer (&fb_info); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@59 PS1, Line 59: printk (BIOS_DEBUG, "Inverse framebuffer color\n"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@61 PS1, Line 61: memset ((void *)FB, 0xffffffff, bytes); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@67 PS1, Line 67: void intelfb_destroy() Bad function definition - void intelfb_destroy() should probably be void intelfb_destroy(void)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@77 PS1, Line 77: void intelfb_clear() Bad function definition - void intelfb_clear() should probably be void intelfb_clear(void)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@100 PS1, Line 100: for(y = 0; y < font_height; y++) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@101 PS1, Line 101: for(x = font_width - 1; x >= 0; x--) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@102 PS1, Line 102: dst32 = (u32 *)(dst + (font_width - x) * (FI.bits_per_pixel >> 3)); line over 80 characters
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@104 PS1, Line 104: *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff; line over 80 characters
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@104 PS1, Line 104: *dst32 = font_glyph_filled(ch, x, y) ? 0: 0xffffffff; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@106 PS1, Line 106: *dst32 = font_glyph_filled(ch, x, y) ? 0xffffffff : 0; line over 80 characters
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@126 PS1, Line 126: switch(position){ space required before the open brace '{'
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@126 PS1, Line 126: switch(position){ space required before the open parenthesis '('
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@136 PS1, Line 136: int_row = (4 *(vres / 5)) - (4 * FONT_SCALE); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/30182/1/src/drivers/intel/fb/fbdriver.c@147 PS1, Line 147: for(index = 0; index < len; index++) { space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)