Ivy Jian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31858
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:1278878 TEST=Verified the mainboard version is from EC's EEPROM.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 --- M src/mainboard/google/hatch/Kconfig 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31858/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index d3ad1a0..5b342e9 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -16,6 +16,9 @@ select SOC_INTEL_CANNONLAKE_MEMCFG_INIT select SOC_INTEL_COFFEELAKE select SYSTEM_TYPE_LAPTOP + select EC_GOOGLE_CHROMEEC_BOARDID + select GOOGLE_SMBIOS_MAINBOARD_VERSION +
if BOARD_GOOGLE_BASEBOARD_HATCH
Ivy Jian has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:1278878 TEST=Verified the mainboard version is from EC's EEPROM.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31858/2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31858
to look at the new patch set (#3).
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:1278878 TEST=Verified the mainboard version is from EC's EEPROM.
Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31858/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig@1... PS3, Line 19: select EC_GOOGLE_CHROMEEC_BOARDID : select GOOGLE_SMBIOS_MAINBOARD_VERSION Can you please arrange this in alphabetical order?
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31858
to look at the new patch set (#4).
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:1278878 TEST=Verified the mainboard version is from EC's EEPROM.
Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31858/4
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31858/3/src/mainboard/google/hatch/Kconfig@1... PS3, Line 19: select EC_GOOGLE_CHROMEEC_BOARDID : select GOOGLE_SMBIOS_MAINBOARD_VERSION
Can you please arrange this in alphabetical order?
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
Patch Set 4: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31858
to look at the new patch set (#5).
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:128385395 TEST=Verified the mainboard version is from EC's EEPROM.
Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/31858/5
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31858 )
Change subject: mb/google/hatch: Query the EC for board version ......................................................................
mb/google/hatch: Query the EC for board version
The board version is part of EC's EEPROM, select Kconfig items to enable requesting the EC for board version.
BUG=b:128385395 TEST=Verified the mainboard version is from EC's EEPROM.
Change-Id: I4bc1cac43c6cf73522f3a4bee89cc000a430d996 Signed-off-by: Ivy Jian ivy_jian@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31858 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index c200845..3853c30 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -8,7 +8,9 @@ select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC + select GOOGLE_SMBIOS_MAINBOARD_VERSION select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_LPSS_UART_FOR_CONSOLE
-
Furquan Shaikh (Code Review) -
Ivy Jian (Code Review)
-
Patrick Georgi (Code Review)