Attention is currently required from: Alexander Couzens.
Maxim has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84191?usp=email )
Change subject: util/intelp2m/platforms: Add support for Elkhart Lake ......................................................................
Patch Set 4:
(6 comments)
Patchset:
PS4: 1) Add unit tests. 2) Rebase to the top of the topic `pad2macro` - https://review.coreboot.org/q/topic:%22pad2macro%22 . 3) Use `Apollo Lake SoC` as the base platform. 4) `make test` = PASS. 5) `./intelp2m -platform ehl -file parser/testlog/inteltool_test.log` = no errors
File util/intelp2m/platforms/ehl/macro.go:
https://review.coreboot.org/c/coreboot/+/84191/comment/e0a89480_d4a50b8c?usp... : PS3, Line 151: func (PlatformSpecific) GpiMacroAdd() {
Done
https://review.coreboot.org/c/coreboot/+/84191/comment/5c8f5fb3_580efce5?usp... : PS3, Line 204: func (PlatformSpecific) GpoMacroAdd() {
Done
https://review.coreboot.org/c/coreboot/+/84191/comment/98108515_0fce05ba?usp... : PS3, Line 236: func (PlatformSpecific) NativeFunctionMacroAdd() {
Done
https://review.coreboot.org/c/coreboot/+/84191/comment/46c12844_6cc4e85a?usp... : PS3, Line 268: func (PlatformSpecific) NoConnMacroAdd() {
Done
https://review.coreboot.org/c/coreboot/+/84191/comment/d97a7188_680ff074?usp... : PS3, Line 302: macro := common.GetInstanceMacro(PlatformSpecific{}, fields.InterfaceGet())
Done