Attention is currently required from: Paul Menzel, Yu-Ping Wu.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59539 )
Change subject: soc/mediatek/i2c: Return negative values on error
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/soc/mediatek/common/i2c.c:
https://review.coreboot.org/c/coreboot/+/59539/comment/6b1ddf55_1020c219
PS3, Line 282: return ret;
Those enum values have been changed to negative in this patch. […]
oh, sorry, somehow missed that part of the updated patch. yes, then this is correct
https://review.coreboot.org/c/coreboot/+/59539/comment/add13139_cf574894
PS3, Line 317: if (ret < 0)
since mtk_i2c_transfer will return 0 or positive, this condition will always be false. […]
missed the part of the patch that made the defined constants negative numbers, so this is correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59539
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I955b9aae11e20d75fac414d15714330e364dad2f
Gerrit-Change-Number: 59539
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Wei-Shun Chang
weishunc@google.com
Gerrit-Reviewer: Xin Ji
xji@analogix.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 26 Nov 2021 11:28:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment