Attention is currently required from: Angel Pons, Julius Werner.
Moritz Fischer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50886 )
Change subject: soc/rockchip/rk3399/sdram: Clear PI_175 IRQs in data training
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50886/comment/e4433317_16154270
PS1, Line 10: calls.
Is this to ensure training will work properly? It would be nice to mention why this is necessary.
I couldn't figure out how to add a 'cover letter'.
I'm mostly porting stuff from U-Boot. Maybe I should make one giant series instead for better context. I'm trying to do the non-invasive small changes first.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib73f58265db62494282dbec42ec4bf2950617e12
Gerrit-Change-Number: 50886
Gerrit-PatchSet: 1
Gerrit-Owner: Moritz Fischer
moritzf@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 19 Feb 2021 00:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment