Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43765 )
Change subject: Kconfig: Remove unnecessary choice names ......................................................................
Kconfig: Remove unnecessary choice names
The only reason to use a named choice statement is if you plan on having the choice statement in multiple places. Since none of these are used in multiple places, we can get rid of the names.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Ie5f84e9dc38050234976bd193ac5fbf649e564f4 --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/amd/padmelon/Kconfig M src/soc/amd/picasso/Kconfig 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/43765/1
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 599e64a..0913c15 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -70,7 +70,7 @@ default "3rdparty/blobs/mainboard/amd/mandolin/EC_mandolin.bin" if BOARD_AMD_MANDOLIN
if !AMD_LPC_DEBUG_CARD -choice MANDOLIN_LPC_IOMUX +choice prompt "State of IOMux for LPC/eMMC signals" default MANDOLIN_IOMUX_USE_EMMC help diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 428ea84..cbbeb47 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -28,7 +28,7 @@ string default "Padmelon"
-choice PADMELON_SOC +choice prompt "SOC used in padmelon board" default PADMELON_MERLIN_FALCON
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 3bdaad2..aaabf43 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -271,7 +271,7 @@ 2: 0xfedc3000 3: 0xfedcf000
-choice PICASSO_UART_CLOCK_SOURCE +choice prompt "UART Frequency" depends on PICASSO_CONSOLE_UART default PICASSO_UART_48MZ
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43765 )
Change subject: Kconfig: Remove unnecessary choice names ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43765 )
Change subject: Kconfig: Remove unnecessary choice names ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43765 )
Change subject: Kconfig: Remove unnecessary choice names ......................................................................
Patch Set 1:
One instance was missed, CB:43836 takes care of it.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43765 )
Change subject: Kconfig: Remove unnecessary choice names ......................................................................
Kconfig: Remove unnecessary choice names
The only reason to use a named choice statement is if you plan on having the choice statement in multiple places. Since none of these are used in multiple places, we can get rid of the names.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: Ie5f84e9dc38050234976bd193ac5fbf649e564f4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43765 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/amd/mandolin/Kconfig M src/mainboard/amd/padmelon/Kconfig M src/soc/amd/picasso/Kconfig 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/Kconfig b/src/mainboard/amd/mandolin/Kconfig index 599e64a..0913c15 100644 --- a/src/mainboard/amd/mandolin/Kconfig +++ b/src/mainboard/amd/mandolin/Kconfig @@ -70,7 +70,7 @@ default "3rdparty/blobs/mainboard/amd/mandolin/EC_mandolin.bin" if BOARD_AMD_MANDOLIN
if !AMD_LPC_DEBUG_CARD -choice MANDOLIN_LPC_IOMUX +choice prompt "State of IOMux for LPC/eMMC signals" default MANDOLIN_IOMUX_USE_EMMC help diff --git a/src/mainboard/amd/padmelon/Kconfig b/src/mainboard/amd/padmelon/Kconfig index 428ea84..cbbeb47 100644 --- a/src/mainboard/amd/padmelon/Kconfig +++ b/src/mainboard/amd/padmelon/Kconfig @@ -28,7 +28,7 @@ string default "Padmelon"
-choice PADMELON_SOC +choice prompt "SOC used in padmelon board" default PADMELON_MERLIN_FALCON
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 3bdaad2..aaabf43 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -271,7 +271,7 @@ 2: 0xfedc3000 3: 0xfedcf000
-choice PICASSO_UART_CLOCK_SOURCE +choice prompt "UART Frequency" depends on PICASSO_CONSOLE_UART default PICASSO_UART_48MZ
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)