Attention is currently required from: Arthur Heymans. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/63055
to review the following change.
Change subject: mb/*/BiosCallOuts.c: Fix unused variable ......................................................................
mb/*/BiosCallOuts.c: Fix unused variable
This fixes clang builds.
Change-Id: Ie09fae149a9530ad45f0cd5945e73f46484ef385 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/amd/inagua/BiosCallOuts.c M src/mainboard/amd/persimmon/BiosCallOuts.c M src/mainboard/amd/south_station/BiosCallOuts.c M src/mainboard/amd/union_station/BiosCallOuts.c M src/mainboard/asrock/e350m1/BiosCallOuts.c M src/mainboard/elmex/pcm205400/BiosCallOuts.c M src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c 7 files changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/63055/1
diff --git a/src/mainboard/amd/inagua/BiosCallOuts.c b/src/mainboard/amd/inagua/BiosCallOuts.c index 56a7f53..e7de9e3 100644 --- a/src/mainboard/amd/inagua/BiosCallOuts.c +++ b/src/mainboard/amd/inagua/BiosCallOuts.c @@ -28,13 +28,11 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; MEM_DATA_STRUCT *MemData; UINT32 GpioMmioAddr; UINT8 Data8; UINT8 TempData8;
- FcnData = Data; MemData = ConfigPtr;
Status = AGESA_SUCCESS; @@ -101,13 +99,11 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo;
UINT32 GpioMmioAddr; UINT8 Data8;
- FcnData = Data; ResetInfo = ConfigPtr; GpioMmioAddr = (uintptr_t)acpimmio_gpio_100; Status = AGESA_UNSUPPORTED; diff --git a/src/mainboard/amd/persimmon/BiosCallOuts.c b/src/mainboard/amd/persimmon/BiosCallOuts.c index bee2f9e..46a3308 100644 --- a/src/mainboard/amd/persimmon/BiosCallOuts.c +++ b/src/mainboard/amd/persimmon/BiosCallOuts.c @@ -36,13 +36,11 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo;
UINT32 GpioMmioAddr; UINT8 Data8;
- FcnData = Data; ResetInfo = ConfigPtr; Status = AGESA_UNSUPPORTED; GpioMmioAddr = (uintptr_t)acpimmio_gpio_100; diff --git a/src/mainboard/amd/south_station/BiosCallOuts.c b/src/mainboard/amd/south_station/BiosCallOuts.c index 6216a3f..83f79dd 100644 --- a/src/mainboard/amd/south_station/BiosCallOuts.c +++ b/src/mainboard/amd/south_station/BiosCallOuts.c @@ -28,13 +28,11 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; MEM_DATA_STRUCT *MemData; UINT32 GpioMmioAddr; UINT8 Data8; UINT8 TempData8;
- FcnData = Data; MemData = ConfigPtr;
Status = AGESA_SUCCESS; @@ -101,14 +99,12 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo; UINT32 GpioMmioAddr; UINT8 Data8;
GpioMmioAddr = (uintptr_t)acpimmio_gpio_100;
- FcnData = Data; ResetInfo = ConfigPtr; Status = AGESA_UNSUPPORTED; switch (ResetInfo->ResetId) { diff --git a/src/mainboard/amd/union_station/BiosCallOuts.c b/src/mainboard/amd/union_station/BiosCallOuts.c index c324fd6..0ae60b4 100644 --- a/src/mainboard/amd/union_station/BiosCallOuts.c +++ b/src/mainboard/amd/union_station/BiosCallOuts.c @@ -28,13 +28,11 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; MEM_DATA_STRUCT *MemData; UINT32 GpioMmioAddr; UINT8 Data8; UINT8 TempData8;
- FcnData = Data; MemData = ConfigPtr;
Status = AGESA_SUCCESS; @@ -101,14 +99,12 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo; UINT32 GpioMmioAddr; UINT8 Data8;
GpioMmioAddr = (uintptr_t)acpimmio_gpio_100;
- FcnData = Data; ResetInfo = ConfigPtr; Status = AGESA_UNSUPPORTED; switch (ResetInfo->ResetId) { diff --git a/src/mainboard/asrock/e350m1/BiosCallOuts.c b/src/mainboard/asrock/e350m1/BiosCallOuts.c index 391b308..ac42bd4 100644 --- a/src/mainboard/asrock/e350m1/BiosCallOuts.c +++ b/src/mainboard/asrock/e350m1/BiosCallOuts.c @@ -25,13 +25,11 @@ static AGESA_STATUS board_BeforeDramInit (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; MEM_DATA_STRUCT *MemData; UINT32 GpioMmioAddr; UINT8 Data8; UINT8 TempData8;
- FcnData = Data; MemData = ConfigPtr;
Status = AGESA_SUCCESS; diff --git a/src/mainboard/elmex/pcm205400/BiosCallOuts.c b/src/mainboard/elmex/pcm205400/BiosCallOuts.c index bee2f9e..46a3308 100644 --- a/src/mainboard/elmex/pcm205400/BiosCallOuts.c +++ b/src/mainboard/elmex/pcm205400/BiosCallOuts.c @@ -36,13 +36,11 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - UINTN FcnData; PCIe_SLOT_RESET_INFO *ResetInfo;
UINT32 GpioMmioAddr; UINT8 Data8;
- FcnData = Data; ResetInfo = ConfigPtr; Status = AGESA_UNSUPPORTED; GpioMmioAddr = (uintptr_t)acpimmio_gpio_100; diff --git a/src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c b/src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c index 64ba978..f8a48b8 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c +++ b/src/mainboard/jetway/nf81-t56n-lf/BiosCallOuts.c @@ -39,13 +39,11 @@ static AGESA_STATUS board_GnbPcieSlotReset (UINT32 Func, UINTN Data, VOID *ConfigPtr) { AGESA_STATUS Status; - uint32_t FcnData; PCIe_SLOT_RESET_INFO *ResetInfo;
uint32_t GpioMmioAddr; uint8_t Data8;
- FcnData = Data; ResetInfo = ConfigPtr; Status = AGESA_UNSUPPORTED; GpioMmioAddr = (uintptr_t)acpimmio_gpio_100;