Attention is currently required from: Arthur Heymans, Elyes Haouas, Yu-Ping Wu.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70251?usp=email )
Change subject: Makefile.inc: Use 'Wmissing-include-dirs' command option
......................................................................
Patch Set 34:
(1 comment)
Patchset:
PS34:
This broke compiling with a custom FSP (using `FSP_HEADER_PATH`) if vboot is built.
Really, it's that vboot doesn't fix up include paths correctly (`vboot-fixup-includes`), so includes using absolute paths are broken.
e.g., what should be
-I"/home/tcrawford/Projects/System76/firmware-open/models/addw3/AlderLakeFspBinPkg/Include"
gets converted to
-I/home/tcrawford/Projects/System76/firmware-open/coreboot//home/tcrawford/Projects/System76/firmware-open/models/addw3/AlderLakeFspBinPkg/Include
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70251?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a30c3830f30509deaaadc6eaeab0e17bc08565c
Gerrit-Change-Number: 70251
Gerrit-PatchSet: 34
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: MrChromebox
mrchromebox@gmail.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 04 Aug 2023 17:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment